Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isn't compatible with FluidSynth 2.x #1078

Closed
yurivict opened this issue Nov 25, 2018 · 17 comments
Closed

Isn't compatible with FluidSynth 2.x #1078

yurivict opened this issue Nov 25, 2018 · 17 comments

Comments

@yurivict
Copy link

See log here: https://ptpb.pw/-t-8

@vlazzarini
Copy link
Member

It's known that the fluidsynth opcodes are written for 1.x

@yurivict
Copy link
Author

You should remove the dependency on FluidSynth then is you can't support the new version.

@rorywalsh
Copy link
Contributor

Csound tries to maintain backward compatibility wherever possible. Removing the fluidsynth opcodes could break hundreds of existing Csound instruments that users spent a lot of time developing.

@yurivict
Copy link
Author

You should consider supporting FluidSynth 2.x then, because these users won't be able to use their instruments once their FluidSynth package would update to 2.x.

@rorywalsh
Copy link
Contributor

Is it possible to have both versions installed? Sorry, I know nothing of fluidsynth.

@yurivict
Copy link
Author

@rorywalsh Currently FluidSynth isn't designed to be concurrently installed. It installs /usr/local/bin/fluidsynth, /usr/local/include/fluidsynth/* and /usr/local/lib/libfluidsynth.so.

FluidSynth project could easily uniquify these file names and allow concurrent version installations.

You should contact them and request this since you are the interested party.

@kunstmusik kunstmusik reopened this Nov 25, 2018
@kunstmusik
Copy link
Member

Reopening: let's leave this as a todo to support Fluidsynth 2.x as the problem is coming up often enough that it needs a fix. One path would be to have CMake detect Fluidsynth version and enable build only for 1.x, or other path to conditionally build for either 1.x or 2.x.

@yurivict
Copy link
Author

Following up on what I said, FluidSynth could rename all files with -2 suffix opening the way to concurrent installations. They can do this even now with the next update. This way you could remain on 1.x for a long time. But this needs to be done only with FluidSynths's upstream consent.

@vlazzarini
Copy link
Member

That's a very good idea. Maybe a ticket should be open there.

As for Csound, the fluidsynth opcodes are scheduled to move to their own separate repo.

@vlazzarini
Copy link
Member

I would prefer that this issue is closed as far as Csound is concerned as we have to take these opcodes out of the main repo.

@yurivict
Copy link
Author

FluidSynth rejected the idea of having the ability to install versions concurrently. Consequently, you should either convert to 2.x or abandon FluidSynth entirely, as far as most users go.

@kunstmusik
Copy link
Member

@yurivict Does develop branch now work for you with Fluidsynth 2.x? We merged a PR (#1046) that seems to address it, but I don't have a system with 2.x at the moment to test on.

@yurivict
Copy link
Author

yurivict commented Dec 1, 2018

It doesn't build: #1081

@kunstmusik
Copy link
Member

That seems unrelated to Fluidsynth opcodes, but we'll need to address that.

@yurivict
Copy link
Author

yurivict commented Dec 1, 2018

Yes, but I can't build it to verify because of this.

@dvzrv
Copy link
Contributor

dvzrv commented Jan 8, 2019

Also, this is a dup of #1036

@kunstmusik
Copy link
Member

Fixed as part of #1036.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants