Do not ignore return value of setuid#1335
Closed
jkrshnmenon wants to merge 1 commit intocsound:developfrom
jkrshnmenon:develop
Closed
Do not ignore return value of setuid#1335jkrshnmenon wants to merge 1 commit intocsound:developfrom jkrshnmenon:develop
jkrshnmenon wants to merge 1 commit intocsound:developfrom
jkrshnmenon:develop
Conversation
Member
|
Seems ok, but the appveyor build failed for some reason that might be unrelated, needs to be checked |
Contributor
|
Looks OK to me too I merged by hand and srems OK on Linux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignoring the return value of setuid might lead to a security issue.
Since the csound_main.c creates log files after invoking set_rt_priority,
if setuid fails, these files would be owned by root.