New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to declare multiple fonts as a single value #21

Closed
RGBboy opened this Issue Dec 22, 2015 · 3 comments

Comments

Projects
None yet
5 participants
@RGBboy

RGBboy commented Dec 22, 2015

If I declare a value as a series of font names:

@value defaultFont: "Helvetica Neue", Helvetica, Arial, sans-serif;

and use that within a css module

.example {
  font-family: defaultFont;
}

I get the following output:

.example {
  font-family: "Helvetica Neue";
}

Ideally I would like this to output:

.example {
  font-family: "Helvetica Neue", Helvetica, Arial, sans-serif;
}

It would also be nice if I could compose values into a new value:

@value defaultFont: "Helvetica Neue", Helvetica, Arial, sans-serif;
@value specialFont: "MySpecialFont", defaultFont;
.example {
  font-family: specialFont;
}

Is this something worth implementing here? Or should I just resort to using the composes method?

@axelson

This comment has been minimized.

Show comment
Hide comment
@axelson

axelson Apr 18, 2016

Can we get common pitfalls such as this added to the README?

axelson commented Apr 18, 2016

Can we get common pitfalls such as this added to the README?

@kevinSuttle

This comment has been minimized.

Show comment
Hide comment
@kevinSuttle

kevinSuttle May 25, 2016

Yeah this is a really weird one. Causes very strange behavior in browsers.

kevinSuttle commented May 25, 2016

Yeah this is a really weird one. Causes very strange behavior in browsers.

@gilmoreorless

This comment has been minimized.

Show comment
Hide comment
@gilmoreorless

gilmoreorless Sep 6, 2016

Looks like this is fixed now that #23 has been merged and released in 1.2.0

gilmoreorless commented Sep 6, 2016

Looks like this is fixed now that #23 has been merged and released in 1.2.0

@geelen geelen closed this Sep 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment