From 1ccbd5b29e1b2121efaf7b24a69aa782848966dc Mon Sep 17 00:00:00 2001
From: wongjn <11310624+wongjn@users.noreply.github.com>
Date: Wed, 1 Apr 2020 11:13:19 +0100
Subject: [PATCH] fix: units being removed in math functions (#894)

---
 .all-contributorsrc                                    | 9 +++++++++
 jest.config.js                                         | 1 +
 packages/postcss-convert-values/src/__tests__/index.js | 6 ++++++
 packages/postcss-convert-values/src/index.js           | 7 ++++++-
 4 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/.all-contributorsrc b/.all-contributorsrc
index 3995ef306..ceed342e4 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -591,6 +591,15 @@
       "contributions": [
         "platform"
       ]
+    },
+    {
+      "login": "wongjn",
+      "name": "wongjn",
+      "avatar_url": "https://avatars2.githubusercontent.com/u/11310624?v=4",
+      "profile": "https://github.com/wongjn",
+      "contributions": [
+        "code"
+      ]
     }
   ],
   "repoType": "github"
diff --git a/jest.config.js b/jest.config.js
index 5f6d4ae4e..1a32235c0 100644
--- a/jest.config.js
+++ b/jest.config.js
@@ -10,4 +10,5 @@ module.exports = {
     '_processCss.js',
     '_webpack.config.js',
   ],
+  testTimeout: 30000,
 };
diff --git a/packages/postcss-convert-values/src/__tests__/index.js b/packages/postcss-convert-values/src/__tests__/index.js
index 425661216..0358bd4b6 100644
--- a/packages/postcss-convert-values/src/__tests__/index.js
+++ b/packages/postcss-convert-values/src/__tests__/index.js
@@ -351,6 +351,12 @@ test(
   passthroughCSS('h1{line-height:0rem}')
 );
 
+test('should keep unit in max()', passthroughCSS('h1{margin:max(0px)}'));
+
+test('should keep unit in min()', passthroughCSS('h1{margin:min(0px)}'));
+
+test('should keep unit in clamp()', passthroughCSS('h1{margin:clamp(0px)}'));
+
 test(
   'should keep unknown units or hacks',
   passthroughCSS('h1{top:0\\9\\0;left:0lightyear}')
diff --git a/packages/postcss-convert-values/src/index.js b/packages/postcss-convert-values/src/index.js
index 7da38f84b..59995de6c 100644
--- a/packages/postcss-convert-values/src/index.js
+++ b/packages/postcss-convert-values/src/index.js
@@ -106,7 +106,12 @@ function transform(opts, decl) {
           });
           return false;
         }
-        if (lowerCasedValue === 'url') {
+        if (
+          lowerCasedValue === 'url' ||
+          lowerCasedValue === 'min' ||
+          lowerCasedValue === 'max' ||
+          lowerCasedValue === 'clamp'
+        ) {
           return false;
         }
       }