Made sure rebasing is truly aborted

If a negative z-index isn’t the first z-index value, all z-index values remain unchanged. Also, added a warning.
cssnano · Feb 16, 2017 · 6074b01 · 6074b01
1 parent 792d43e
commit 6074b01
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/packages/postcss-zindex/index.js b/packages/postcss-zindex/index.js
@@ -21,6 +21,11 @@ module.exports = postcss.plugin('postcss-zindex', function () {
             nodes.push(decl);
             cache.addValue(decl.value);
         });
+
+        // Abort rebasing altogether due to z-index being found
+        if (abort) {
+            return;
+        }
 
         cache.optimizeValues();
 

diff --git a/packages/postcss-zindex/test.js b/packages/postcss-zindex/test.js
@@ -45,8 +45,8 @@ var tests = [{
     expected: 'h1{color:black;font-weight:bold}'
 }, {
     message: 'should abort early if any negative z-indices were found',
-    fixture: '.a{z-index:-2}.b{z-index:10}.c{z-index:8}.d{z-index:6}',
-    expected: '.a{z-index:-2}.b{z-index:10}.c{z-index:8}.d{z-index:6}'
+    fixture: '.a{z-index:8}.b{z-index:-2}.c{z-index:10}.d{z-index:8}.e{z-index:6}',
+    expected: '.a{z-index:8}.b{z-index:-2}.c{z-index:10}.d{z-index:8}.e{z-index:6}'
 }];
 
 function process (css, options) {