Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid minification of var() fallback #822

Closed
JaneOri opened this issue Oct 1, 2019 · 1 comment · Fixed by #835
Closed

Invalid minification of var() fallback #822

JaneOri opened this issue Oct 1, 2019 · 1 comment · Fixed by #835

Comments

@JaneOri
Copy link

JaneOri commented Oct 1, 2019

Playground Input:

div {
  border-radius: 10px var(--foobar, );
}

Actual output

div{border-radius:10px var(--foobar,)}

(the empty fallback in var() is invalid and results in the whole rule being ignored. The space is required)

Expected output

div{border-radius:10px var(--foobar, )}

(must have the space in the fallback value to be valid)

Could be an issue somewhere upstream in postcss - happy to submit a PR either way if someone familiar with the code bases could point me roughly near the code that would be responsible.

@alexander-akait
Copy link
Member

alexander-akait commented Oct 1, 2019

Yep, PR welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants