Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postcss-merge-longhand): mergeLonghand should not apply to CSS variables #1057

Merged
merged 1 commit into from Apr 26, 2021

Conversation

@KKoukiou
Copy link
Contributor

@KKoukiou KKoukiou commented Apr 26, 2021

Fixes #1051

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Apr 26, 2021

Codecov Report

Merging #1057 (263fa61) into master (15da338) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1057      +/-   ##
==========================================
+ Coverage   97.54%   97.57%   +0.02%     
==========================================
  Files         116      116              
  Lines        3583     3583              
  Branches     1059     1058       -1     
==========================================
+ Hits         3495     3496       +1     
+ Misses         81       80       -1     
  Partials        7        7              
Impacted Files Coverage Δ
...ges/postcss-merge-longhand/src/lib/decl/borders.js 97.92% <100.00%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15da338...263fa61. Read the comment docs.

@KKoukiou
Copy link
Contributor Author

@KKoukiou KKoukiou commented Apr 26, 2021

@alexander-akait thanks a lot for the super fast review process!

@ludofischer ludofischer merged commit 8aa64c7 into cssnano:master Apr 26, 2021
11 checks passed
@KKoukiou KKoukiou deleted the merge-longhand-vars branch Apr 27, 2021
KKoukiou added a commit to cockpit-project/cockpit that referenced this issue Jun 7, 2021
Disable mergeLongHand in cssnano.

The official fix has already landed upstream [1] but we unfortunately can't
update cssnano without updating also CssMinimizerPlugin.
An update of CssMinimizerPlugin will not work without webpack-5.

Therefore let's keep the WA for now.

[1] cssnano/cssnano#1057
KKoukiou added a commit to KKoukiou/starter-kit that referenced this issue Jun 8, 2021
KKoukiou added a commit to KKoukiou/starter-kit that referenced this issue Jun 8, 2021
KKoukiou added a commit to skobyda/cockpit-certificates that referenced this issue Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants