New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(postcss-colormin): Strict color parsing #1122
fix(postcss-colormin): Strict color parsing #1122
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add tests to ensure we don't break it again
How do you work with the integration tests BTW? They are HUGE and it seems impossible to check them. |
Agree, we need improve them, right now you can use smart diff locally and found which characters was changed (and maybe found regression) |
Ooof. Your integrations tests are killing me
Help would be really appreciated since I'm a rookie in the repo. |
git diff --word-diff
…On Fri, 21 May 2021, 16:00 Vlad Shilov, ***@***.***> wrote:
Ooof. Your integrations tests are killing me
|
Snapshots are fixed (tons of So we should be ready to go! |
Codecov Report
@@ Coverage Diff @@
## master #1122 +/- ##
==========================================
- Coverage 96.37% 96.36% -0.01%
==========================================
Files 115 115
Lines 3582 3575 -7
Branches 1054 1051 -3
==========================================
- Hits 3452 3445 -7
Misses 121 121
Partials 9 9
Continue to review full report at Codecov.
|
/cc @ludofischer can you look too? I think we need do release after merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems straightforward enough to me. Let's try and release this!
Thanks a lot @omgovich for your hard work! |
Thanks for the quick work on this guys. |
Always glad to help. Let me know if you need something else :) |
Fixes #1120
Fixes #1115
Fixes #1113
Colord v2 conforms to CSS Color Level Specs and ignores invalid
<color>
values, so upgrading will fix all of the issues we got last few days.See omgovich/colord#53 for more details.