Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use workspaces #1140

merged 1 commit into from Jun 3, 2021

chore: use workspaces #1140

merged 1 commit into from Jun 3, 2021


Copy link

Yarn 1 has no way to run a command in every workspace, so for now lerna is needed. I am not sure which one of the other package managers would be best at the moment.

  • Updating dependencies is faster though as there is a single yarn.lock.
  • When testing rush which isolates workspace dependencies, I have noticed the build script in the individual packages rely on del-cli and babel-node without declaring them in their own package.json, but I did not fix this as it seems annoying to update these dependencies in every package.

Copy link

codecov-commenter commented Jun 2, 2021

Codecov Report

Merging #1140 (6adb5ed) into master (a63dabf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1140   +/-   ##
  Coverage   96.43%   96.43%           
  Files         116      116           
  Lines        3593     3593           
  Branches     1054     1054           
  Hits         3465     3465           
  Misses        119      119           
  Partials        9        9           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a63dabf...6adb5ed. Read the comment docs.

* Replace deprecated prepublish with prepare
* Ensure packages build before testing by running the prepare script through lerna
@ludofischer ludofischer merged commit 36cef92 into master Jun 3, 2021
10 checks passed
@ludofischer ludofischer deleted the workspaces branch June 3, 2021 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants