New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(postcss-reduce-initial): fix build command #1170
Conversation
- Fix outdated babel --ignore for the acquire script
Codecov Report
@@ Coverage Diff @@
## master #1170 +/- ##
=======================================
Coverage 96.55% 96.55%
=======================================
Files 116 116
Lines 3627 3627
Branches 1065 1065
=======================================
Hits 3502 3502
Misses 117 117
Partials 8 8 Continue to review full report at Codecov.
|
Does the project have any rules/guidelines/common practises when it comes to merging into master - beyond having approval of at least one other with write access? E.g. being handled by certain individuals, not merging own PRs, or that kind of things? And is there anything in particular you pay attention to? From what I've gathered you always squash multiple commits? Thought I'd ask before doing, and also in the interest of documenting it at some point =) |
I don't think there are any special guidelines, as long as somebody else reviews your PRs. @alexander-akait has most permissions on this project. As you can see from the commit history, the people who started the project and contributed most of the code doing the actual transformations have mostly stopped contributing a few years ago, since then there haven't been many committers at all, so I think there never was a need to establish precise guidelines. |
I generally don't merge PRs immediately after approving them to let others have a chance of looking at them. |
Good to know - thanks :-) |
This pull request aims to fix an outdated babel
--ignore
for thepostcss-reduce-initial
acquire scriptIt was overlooked in #1169