Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(postcss-merge-rules): check for ms vendor #480

Merged
merged 3 commits into from May 29, 2018

Conversation

@evless
Copy link
Contributor

@evless evless commented May 29, 2018

fixes #419

@ai
Copy link
Member

@ai ai commented May 29, 2018

Maybe we should check not just prefix but whole selector? To be sure that it is placeholder selector?

@evilebottnawi
Copy link
Member

@evilebottnawi evilebottnawi commented May 29, 2018

Yep, looks like better use -ms-input-placeholder whole selector and add comment to future developers:

Internet Explorer use :-ms-input-placeholder.
Microsoft Edge use ::-ms-input-placeholder.
@coveralls
Copy link

@coveralls coveralls commented May 29, 2018

Coverage Status

Coverage increased (+0.0004%) to 99.488% when pulling 465cf52 on evless:fix/ms-vendors into 172f1af on ben-eb:master.


// Internet Explorer use :-ms-input-placeholder.
// Microsoft Edge use ::-ms-input-placeholder.
const findMsInputPlaceholder = selector => ~selector.indexOf('-ms-input-placeholder');

This comment has been minimized.

@evilebottnawi

evilebottnawi May 29, 2018
Member

Better use regex with i flag, because css is case insensitivity language

This comment has been minimized.

@evless

evless May 29, 2018
Author Contributor

Oh, well, I did not think about it

@evilebottnawi evilebottnawi merged commit e4e55d1 into cssnano:master May 29, 2018
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0004%) to 99.488%
Details
security/snyk No dependency changes
Details
@evilebottnawi
Copy link
Member

@evilebottnawi evilebottnawi commented May 29, 2018

@evless Thanks for work!

@evless
Copy link
Contributor Author

@evless evless commented May 29, 2018

@evilebottnawi I apologize, but can I make a commit with the addition of a list of contributors? :)

@evilebottnawi
Copy link
Member

@evilebottnawi evilebottnawi commented May 29, 2018

@evless yep, feel free to send PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.