Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
fix ben-eb/cssnano/448 don't remove fallbacks for custom css properties #486
referenced this pull request
Jun 3, 2018
Can you add a test where the properties are mixed up to demonstrate its correctness? E.g.:
Alright, the implementation looks good. I was a bit confused by the odd ordering of the properties in the tests until I realised I was looking at integration tests (the reordering is due to css-declaration-sorter).
I'd like some unit tests where we test the plugin in isolation as well, if you don't mind (under
Apart from that, it looks really good. Good job!
/home/stanislav/projects/cssnano/packages/postcss-merge-longhand/src/__tests__/borders.js 316:5 error 'processCss' is not defined no-undef 323:5 error 'processCss' is not defined no-undef 330:5 error 'processCss' is not defined no-undef
/home/stanislav/projects/cssnano/packages/postcss-merge-longhand/src/__tests__/columns.js 75:5 error 'processCss' is not defined no-undef
Change it to