Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for checking issue #420 #504

Merged
merged 4 commits into from Jun 6, 2018

Conversation

Projects
None yet
2 participants
@kuflash
Copy link
Contributor

kuflash commented Jun 5, 2018

Test for checking integration with postcss-font-magician with display parameter.

fixes #420

@kuflash

This comment has been minimized.

Copy link
Contributor Author

kuflash commented Jun 5, 2018

Now it's failed, but with new release postcss-font-magician should pass successfully

@evilebottnawi

This comment has been minimized.

Copy link
Member

evilebottnawi commented Jun 5, 2018

@kuflash thanks!

@@ -32,7 +32,7 @@
"cross-env": "^5.1.6",
"cssnano-preset-advanced": "^4.0.0-rc.2",
"ncp": "^2.0.0",
"postcss-font-magician": "^2.0.0",
"postcss-font-magician": "2.2.0",

This comment has been minimized.

@evilebottnawi

evilebottnawi Jun 5, 2018

Member

please use ^

kuflash added some commits Jun 5, 2018

@kuflash

This comment has been minimized.

Copy link
Contributor Author

kuflash commented Jun 5, 2018

@evilebottnawi maybe need restart Travis and Appveyor? Because there is a strange problem at the stage of installing packages

@evilebottnawi

This comment has been minimized.

Copy link
Member

evilebottnawi commented Jun 5, 2018

@kuflash looks yarn broken 😕 let't try restart

@evilebottnawi

This comment has been minimized.

Copy link
Member

evilebottnawi commented Jun 5, 2018

@kuflash oh, postcss-font-magician require nodejs@6, thanks for PR. I will drop nodejs@4 tomorrow and merge you PR, on other version all works fine 👍

@kuflash

This comment has been minimized.

Copy link
Contributor Author

kuflash commented Jun 5, 2018

@evilebottnawi thank you!

@evilebottnawi evilebottnawi merged commit 54f1953 into cssnano:master Jun 6, 2018

2 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
coverage/coveralls First build on master at 99.45%
Details
security/snyk No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.