fix(postcss-colormin): Fix bug where color value is mutated #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sforming to hsl Fixes cssnano#545
|
@evilebottnawi I've update the existing test case for rgba to hsla to cover that use-case plus updated the expected result of two others that change along with this fix. |
|
@weaintplastic thanks 👍 |
alexander-akait
approved these changes
Jul 12, 2018
andyjansson
suggested changes
Jul 12, 2018
| @@ -6,7 +6,7 @@ import { | |||
| processCSSWithPresetFactory, | |||
| } from '../../../../util/testHelpers'; | |||
|
|
|||
| const {passthroughCSS, processCSS} = processCSSFactory(plugin); | |||
| const { passthroughCSS, processCSS } = processCSSFactory(plugin); | |||
There was a problem hiding this comment.
This is causing issues with our linting settings.
There was a problem hiding this comment.
@andyjansson Sorry, I've missed that and fixed it with the next commit.
|
@andyjansson integration tests have been updated and CI check is green. Thanks for your direction. 🙌🏻 |
|
/cc @andyjansson |
|
@andyjansson looks good for me, merge, feel free to feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where color value is mutated when tranforming to hsl
Fixes #545