apply new test suite to more plugins and sourcemap fixes #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
Jan 21, 2022
| AtRule: { | ||
| mixin(node, { postcss }) { | ||
| node.replaceWith(postcss().process('& .in{ &.deep { color: blue; }}', {from : 'mixin.css'}).root); | ||
| node.replaceWith(postcss.parse('& .in{ &.deep { color: blue; }}', {from : 'mixin.css'})); |
Member
Author
There was a problem hiding this comment.
This was triggering PostCSS to warn about now having any plugins.
Using .parse resolves this.
romainmenke
commented
Jan 21, 2022
| const media = postcss.atRule({ | ||
| name: 'media', | ||
| params: `(-webkit-min-device-pixel-ratio: ${dpr}), (min-resolution: ${dpi}dpi)`, | ||
| source: decl.source, |
Member
Author
There was a problem hiding this comment.
This fixes the sourcemaps issue
romainmenke
deleted the
apply-new-test-suite-to-more-plugons-and-sourcemap-fix--reliable-fin-whale-a7dbd25e43
branch
romainmenke
added a commit
that referenced
this pull request
Jan 31, 2022
* 7.3 * add `postcss-is-pseudo-class` to `postcss-preset-env` and `cli` (#159) * add postcss-is-pseudo-class to preset-env and cli * add test * cli : emit warnings (#164) * cli : emit warnings * update change log * Adding debug option (#163) * Updating dependencies * Simplifying Object usaging * Clearer stage * Adding debug * Adding documentation * Useful on issues too * eslint enforce radix in parseInt * Naive approach to using result.warn * Clamping * Switching for better clarity * Update plugin-packs/postcss-preset-env/src/index.js Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com> * Update plugin-packs/postcss-preset-env/src/index.js Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com> * 7.3 * add `postcss-is-pseudo-class` to `postcss-preset-env` and `cli` (#159) * add postcss-is-pseudo-class to preset-env and cli * add test * Updating CHANGELOG * Fixing link * Fixing changelog Co-authored-by: romainmenke <romainmenke@gmail.com> Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com> * Disable javascript features (#167) * Updating dependencies * Simplifying Object usaging * Clearer stage * Adding debug * Adding documentation * Useful on issues too * eslint enforce radix in parseInt * Naive approach to using result.warn * Clamping * Switching for better clarity * Update plugin-packs/postcss-preset-env/src/index.js Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com> * Update plugin-packs/postcss-preset-env/src/index.js Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com> * 7.3 * add `postcss-is-pseudo-class` to `postcss-preset-env` and `cli` (#159) * add postcss-is-pseudo-class to preset-env and cli * add test * Updating CHANGELOG * Fixing link * Fixing changelog * Moving to separate file * Adding option that disables client side polyfills * Adding useful logging to debug mode * Consistency * Adding meaningful tests * Updating README * Update plugin-packs/postcss-preset-env/README.md Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com> * Adding missing library Co-authored-by: romainmenke <romainmenke@gmail.com> Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com> * apply new test suite to more plugins and sourcemap fixes * Revert "apply new test suite to more plugins and sourcemap fixes" This reverts commit b94037e. * apply new test suite to more plugins and sourcemap fixes (#182) * apply new test suite to more plugins and sourcemap fixes * cleanup dev dependencies * Removing Can I Use Lite (#185) * Getting things up to date * Creating a query for browsers from given browser support * Updating tests * Moving to cssdb feature * Using the new logic with logs too * Allowing `.` for float versions * Updating package * flip disableClientSidePolyfills (#189) * :any-link fixes (#183) * :any-link fixes * update tests * update tests * make it work without :is * postcss-hwb-function in preset-env / cli (#190) * postcss-hwb-function in preset-env / cli * add a test for hwb in preset-env * merge * add a shortcut to rewrite expect files and log warnings (#193) * add a shortcut to rewrite expect files * emit warnings if they don't match * Adding Opacity Percent Feature (#196) * Updating badges (#197) * Replacing all chat badges * Adding package phobia #165 * Adding PostCSS clamp (#198) * Adding postcss-clamp * Updating CHANGELOG * New test for preserve: true with every feature enabled * postcss-is-pseudo-class : better warnings and skip (#199) * wip * wip * wip * wip * wip * finish * Getting ready-er * Integrate font & display plugins (#205) * Adding two new plugins * Adding missing plugins to the CLI * postcss-is-pseudo-class : browser tests and transform in 2 stages (#212) * postcss-is-pseudo-class : browser tests * postcss-is-pseudo-class: 2 stage transform * cleanup * postcss-preset-env: filter features by implementation status (#211) * postcss-preset-env: filter by implementation status * tweak * fix insertBefore/insertAfter * fix * few more tests and simplify postcss-tape expect/result option * fix * update docs * postcss-preset-env: pin some features to stage: 1 (#213) * Adding more to the README (#207) * Adding more to the README #202 * Updating docs * Update plugin-packs/postcss-preset-env/README.md Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com> * Update plugin-packs/postcss-preset-env/README.md Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com> * Update plugin-packs/postcss-preset-env/README.md Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com> * Update plugin-packs/postcss-preset-env/README.md Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com> * Update plugin-packs/postcss-preset-env/README.md Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com> Co-authored-by: Romain Menke <11521496+romainmenke@users.noreply.github.com> * Updating CSSDB to latest version * Tests fixing * Test after building * Upgrading all deps * Updating packages Co-authored-by: Antonio Laguna <sombragriselros@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postcss-preset-envand a few more plugins now use the new test suite.image-set-functionpostcss-tapeto handle thisI also created an issue to remove these exceptions as it goes against plugin best practices.