todo-or-die #809
todo-or-die #809
Conversation
…-long-eared-owl-f30a120073
| if (response.statusCode !== 200) { | ||
| rejected = true; | ||
| reject(new Error('Failed to fetch issue status')); | ||
| return; | ||
| } |
There was a problem hiding this comment.
I was wondering what happens if you don't have visibility to an issue because you're lacking the token or whatever I feel this should at least be surfaced somehow since you might think it's working but perhaps it isn't. So the build does not fail but at least the plugin informs the user
There was a problem hiding this comment.
I am going to remove the "issue open" feature entirely :)
todo-or-die for Rust has this feature, but you compile Rust much less frequently than you build CSS during development. When working in Rust or Go I don't use a file watcher to re-compile.
Doing so many builds so frequently is bound to cause false errors because it depends on the network. You also should be able to work offline without seeing errors.
I think it makes more sense to remove this, and maybe later add something that allows people to easily add custom checks.
There was a problem hiding this comment.
@romainmenke this is looking great! I left some questions even if this wasn't ready to be reviewed :P
Thank you for those! I was hoping to find some solution to the "issue-open" feature, but as I said above I don't see a way to make work well within a CSS toolkit. I'd rather streamline the plugin a bit now and ship it 🚀 |
romainmenke
deleted the
todo-or-die--generous-long-eared-owl-f30a120073
branch
replaces : #757
readme : https://github.com/csstools/postcss-plugins/tree/todo-or-die--generous-long-eared-owl-f30a120073/plugins/postcss-todo-or-die#readme