New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
css-color-parser + postcss-color-mix-function
#877
css-color-parser + postcss-color-mix-function
#877
Conversation
…erous-aye-aye-679d05f6e2
…erous-aye-aye-679d05f6e2
…erous-aye-aye-679d05f6e2
css-color-parser + postcss-color-mix-function
…erous-aye-aye-679d05f6e2
…erous-aye-aye-679d05f6e2
…erous-aye-aye-679d05f6e2
…erous-aye-aye-679d05f6e2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
I had to review this on the editor since this is a huge change and makes the browser suffer a lot.
This is so great to have it finally there! I'm really looking forward to this getting merged and out in the wild.
Thanks for all the work and the changes around the tooling and the other color functions!
|
Thank you for working through this massive review 🙇 |
css-color-parserpackagepostcss-color-mix-functionpluginpostcss-hwb-functionpluginpostcss-lab-functionpluginpostcss-oklab-functionpluginpostcss-color-functionplugincolor-helperspackageThings I skipped/didn't change :
postcss-color-functional-notation, technicallycss-color-parsercan help here, but this plugin is more a syntax desugaring and not really a color transformI think this is ready to be shipped as a standalone plugin.
There are a few minor open issues I still want to wait on before adding to
postcss-preset-env. It seems that browsers have incorrect implementations for a wide range of cases and I don't want to add topostcss-preset-envbefore confirmation that our implementation is correct.Footnotes
'blacK'.toLowerCase() === 'black'butKisn't actually an upper casek. It is a different unicode char that is equivelant to an upper casekin certain locales. ↩