Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-apple-system is missing for font-family property #20

Closed
andreypopp opened this issue Sep 20, 2016 · 5 comments
Closed

-apple-system is missing for font-family property #20

andreypopp opened this issue Sep 20, 2016 · 5 comments

Comments

@andreypopp
Copy link
Author

@andreypopp andreypopp commented Sep 20, 2016

Ok, I see font-family isn't specified at all as for now.

@andreypopp andreypopp closed this Sep 20, 2016
@andreypopp
Copy link
Author

@andreypopp andreypopp commented Sep 21, 2016

Ok, reopening because I think it is worth describing constants like monospace, serif, sans-serif and system along with some prefixed ones like -apple-system. What do you think?

@andreypopp andreypopp reopened this Sep 21, 2016
@lahmatiy
Copy link
Member

@lahmatiy lahmatiy commented Sep 21, 2016

@andreypopp You are talking about <generic-family>. All keywords except system are defined, see font-family syntax.
I'm not sure about adding -apple-system (unprefixed version nobody supports so we shouldn't add it for sure). But current syntax allows using -apple-system w/o additions.
image

@andreypopp
Copy link
Author

@andreypopp andreypopp commented Sep 21, 2016

I'm interested in having as much information about types of values as possible. Even if -apple-system is allows it won't show up as a suggestion if we don't describe it, for example.

Feel free to close the issue. I can fix that on my side with a set of patches if needed.

@lahmatiy lahmatiy closed this in 5c16336 Sep 21, 2016
@andreypopp
Copy link
Author

@andreypopp andreypopp commented Sep 21, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.