Permalink
Browse files

Merge branch 'feature/responsive'

2 parents f6b2fce + 53f47db commit 89cbff82652bf440f0782e8a8719a7da284a2bcf @csswizardry committed Jan 13, 2013
Showing with 5 additions and 2 deletions.
  1. +1 −0 _vars.scss
  2. +4 −2 inuit.css/base/_images.scss
View
@@ -46,6 +46,7 @@ $brand-round: 4px!default;
* Responsiveness?
*/
$responsive: true!default;
+$flexible-media: true!default;
/**
* Responsive push and pull produce a LOT of code, only turn them on if you
@@ -5,8 +5,10 @@
* Demo: jsfiddle.net/inuitcss/yMtur
*/
img{
- max-width:100%;
- height:auto;
+ @if $flexible-media == true{
+ max-width:100%;
+ height:auto;
+ }
}

5 comments on commit 89cbff8

@silvenon
Contributor

This doesn't solve the problem of wanting to have some of the images on the site non-responsive (avatars, for example). So the selector should definitely be something more specific than img.

I'll try to think of a solid solution later, instead of just being annoying :)

@csswizardry
Owner

I’ll think about a solution that uses selectors like img[width]{} and img[height]{} – can’t get more accurate than that, I guess…

@stefsullrew

I'm in agreement with silvenon here. Some images should be responsive, but not all. I have avatars all over the site and I definitely don't desire responsiveness there.

I have the added issue of having to consume HTML email within my platform/application. (Normalize used to contain img {height:auto;} but appears to no longer.) Setting the height property to auto on all images causes great problems where the images size might be changed via the height attribute in the HTML — but then my CSS overrides it, and the images are a wreck. There's no "reset" for height:auto that I can find.

A method of applying the responsiveness for images you want responsive is much more desirable for our use.

@silvenon
Contributor

This issue was finally resolved in #111 with 7adb6d4.

Please sign in to comment.