Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI test setup #42

Merged
merged 5 commits into from Apr 9, 2019

Conversation

Projects
None yet
2 participants
@aryue123321
Copy link
Collaborator

aryue123321 commented Mar 30, 2019

No description provided.

@aryue123321 aryue123321 requested a review from MatthewMerrill Mar 30, 2019

import { expect } from "chai";
const puppeteer = require("puppeteer");

const baseUrl = "https://tbd.mattmerr.com";

This comment has been minimized.

Copy link
@MatthewMerrill

MatthewMerrill Apr 7, 2019

Collaborator

We'll want to make this localhost or something, right now it's opening browser to tbd.mattmerr.com. I'm not sure how we can launch a jekyll server while in the test though. Maybe exec "bundle exec jekyll serve" with an unusual port?

This comment has been minimized.

Copy link
@aryue123321

aryue123321 Apr 9, 2019

Author Collaborator

http://127.0.0.1:4000 is the default localhost address of jekyll
to run this test, have to open another terminal to lanch the distrition to localhost
the command is jekyll serve

@MatthewMerrill
Copy link
Collaborator

MatthewMerrill left a comment

See comments, otherwise LGTM

MatthewMerrill and others added some commits Apr 9, 2019

Update test/uiTesting/mainPage.test.js
Co-Authored-By: aryue123321 <44553958+aryue123321@users.noreply.github.com>
Update test/uiTesting/mainPage.test.js
Co-Authored-By: aryue123321 <44553958+aryue123321@users.noreply.github.com>

@aryue123321 aryue123321 merged commit b8cca3d into master Apr 9, 2019

1 check passed

netlify/amazing-goodall-48bcfe/deploy-preview Deploy preview ready!
Details

@aryue123321 aryue123321 deleted the puppeteer_setup branch Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.