New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceLink broke on AppVeyor #197

Closed
onovotny opened this Issue Apr 20, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@onovotny

onovotny commented Apr 20, 2017

We just started seeing failures with SourceLink running on AppVeyor starting yesterday:
https://ci.appveyor.com/project/dotnetfoundation/rx-net-la3iv/build/4.0.0-PullReq00391.310.build.325#L2334

[00:01:59]      2>SourceLinkCreate:
[00:01:59]          unable to find repository origin with: dotnet sourcelink-git origin
[00:01:59]      2>Done Building Project "C:\projects\rx-net-la3iv\Rx.NET\Source\src\System.Reactive\System.Reactive.csproj" (default targets) -- FAILED.

Building locally works fine...

In the latest develop branch, I had to set a property to disable sourcelink: https://github.com/Reactive-Extensions/Rx.NET/blob/e989fdcf259801b4a691d47924f653e2aedcc417/Rx.NET/Source/Directory.build.props#L23

Is there anything you can look into here? not sure what's going on...

@ctaggart

This comment has been minimized.

Owner

ctaggart commented Apr 20, 2017

I'm swamped at the moment. Can you try switching from SourceLink.Create.GitHub to SourceLink.Create.CommandLine? It should be a drop in replacement, except it doesn't automatically embed files. It uses the git command line instead of dotnet sourcelink-git.

@ctaggart

This comment has been minimized.

Owner

ctaggart commented Apr 20, 2017

It would help me out if you also tried setting os: Previous Visual Studio 2017 in appveyor.yml.
https://www.appveyor.com/updates/

@ctaggart

This comment has been minimized.

Owner

ctaggart commented Apr 21, 2017

I need to investigate what is wrong with dotnet sourcelink-git. Rx.NET can use SourceLink.Create.CommandLine, which is new to 2.1. dotnet/reactive#393

@ctaggart

This comment has been minimized.

Owner

ctaggart commented May 1, 2017

I don't think NuGet/Home#5039 is related, but linking to it for my info.

I think it was just an issue with an AppVeyor update on the 18th. SourceLink.Create.GitHub now works again with the latest AppVeyor update from the 24th. https://ci.appveyor.com/project/ctaggart/rx-net/build/26. Using os: Previous Visual Studio 2017 in both appveyor.rx.yml and appveyor.ix.yml should have also fixed it at the time. However, I can no longer test that. Looking at the AppVeyor fixes on the 24th, my guess is that #1508 .NET Core SDK 1.0.1 and 1.0.3 on Visual Studio 2017 image should be pre-cached affected this. Anyway, it works again.

@ctaggart ctaggart closed this May 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment