Case Taintor ctaintor

ctaintor opened pull request rails/rails#18960
@ctaintor
removes documentation that is no longer relevant
1 commit with 0 additions and 4 deletions
@ctaintor
  • @ctaintor 1168eca
    bumps version to include website
@ctaintor
@ctaintor
ctaintor commented on pull request danevron/hours-report-app#9
@ctaintor

+1

@ctaintor
Improve documentation
2 commits with 5 additions and 0 deletions
@ctaintor
@ctaintor
  • @danevron f858e0f
    Another attempt to fix a bug where personal events were created on th…
  • @danevron f65abf2
    Fixes a bug where holidays were not added to timesheets due to a diff…
  • 12 more commits »
ctaintor created repository ctaintor/go-throttle
@ctaintor

I'll add a comment - adds the git revision SHA-1 to a file named REVISION

@ctaintor

didn't mean to have it uncommented. do you think a param is necessary?

@ctaintor

I don't think there's anything unique

@ctaintor

you mean... saying that you don't need to do anything but add the scm :rails_artifact?

@ctaintor

perhaps that should be configurable... but, yea - probably shouldn't be the default

@ctaintor

yes

@ctaintor
ctaintor commented on pull request Ben-M/faraday_connection_pool#1
@ctaintor

perfect :)

@ctaintor

this lambda shouldn't be created with every call to connection_pool_for since it's only necessary the first time - it could be an instance method, …

@ctaintor

should the example match the defaults?

@ctaintor

I think this is a decent-enough description, but I believe the actual code in Net::HTTP is something more similar to... 'if you don't use the conne…