Change default keybindings to use source.go context #2

Merged
merged 2 commits into from Apr 16, 2012

Conversation

Projects
None yet
2 participants
@farces
Contributor

farces commented Apr 16, 2012

Change fixes the keybindings to only apply to files using Go syntax. Previously keybindings were global and broke the build system for other syntaxes (if used via F7). Correctly applies keybindings to both Projects and singular files, tested with both singular and project open with files of another language (either within, or outside of the project).

farces added some commits Apr 16, 2012

changed keybindings to only apply to context: source.go (source synta…
…x). This fixes an issue where SublimeGoBuilds keybindings were applying to all languages, making f5-f7 throw errors on non-go files.
@farces

This comment has been minimized.

Show comment
Hide comment
@farces

farces Apr 16, 2012

Contributor

As an aside, it might be worth adding a Go.sublime-build file with something like this https://gist.github.com/2399847 (and removing the F7 binding from Default.sublime-keymap) so that SublimeGoBuild isn't overriding the Build keybind at all, and better matches how other languages are handled.

Contributor

farces commented Apr 16, 2012

As an aside, it might be worth adding a Go.sublime-build file with something like this https://gist.github.com/2399847 (and removing the F7 binding from Default.sublime-keymap) so that SublimeGoBuild isn't overriding the Build keybind at all, and better matches how other languages are handled.

cthackers added a commit that referenced this pull request Apr 16, 2012

Merge pull request #2 from farces/master
Change default keybindings to use source.go context

@cthackers cthackers merged commit b446473 into cthackers:master Apr 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment