Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the build reproducible #43

Conversation

@lamby
Copy link

lamby commented Oct 9, 2019

Whilst working on the Reproducible Builds effort we noticed that stgit could not be built reproducibly.

This is because the contents of the dynamically-compiled Bash completion script was not being generated in a deterministic manner, as well as the cmdlist.py module.

This was originally filed in Debian as #942009.

Whilst working on the Reproducible Builds effort [0] we noticed
that stgit could not be built reproducibly.

This is because the contents of the dynamically-compiled Bash
completion script was not being generated in a deterministic manner,
as well as the cmdlist.py module.

This was originally filed in Debian as #942009 [1].

 [0] https://reproducible-builds.org/
 [1] https://bugs.debian.org/942009

Signed-off-by: Chris Lamb <lamby@debian.org>
@coveralls

This comment has been minimized.

Copy link

coveralls commented Oct 9, 2019

Pull Request Test Coverage Report for Build 72

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 85.318%

Files with Coverage Reduction New Missed Lines %
stgit/commands/init.py 2 97.96%
Totals Coverage Status
Change from base Build 71: 0.0%
Covered Lines: 6421
Relevant Lines: 7317

💛 - Coveralls
@jpgrayson

This comment has been minimized.

Copy link
Collaborator

jpgrayson commented Oct 11, 2019

Hi @lamby. Thank you for identifying this reproducible build issue and thank you for this PR.

As I looked at this patch and stgit as a whole, I saw opportunities to solve the problem in a different, deeper manner. I also identified reproducibility issues in the generated stg.fish completions that were not addressed by this PR. The fish problems may only have affected Python < 3.6.

In net, I have pushed a more comprehensive repair for this issue, so I am closing this PR.

Questions: is there a way to get feedback from the reproducible builds project about whether stgit now passes its tests? Or will we have to release stgit 0.21(0.20 was released recently) and wait for it to make it into debian unstable?

@jpgrayson jpgrayson closed this Oct 11, 2019
@lamby

This comment has been minimized.

Copy link
Author

lamby commented Oct 12, 2019

Hey, thanks for this!

Questions: is there a way to get feedback from the reproducible builds project about whether stgit now passes its tests? Or will we have to release stgit 0.21(0.20 was released recently) and wait for it to make it into debian unstable?

From the viewpoint of our own testing framework, yes, we will have to wait for the relevant version to be updated in Debian unstable, alas.

@bmwiedemann

This comment has been minimized.

Copy link

bmwiedemann commented Oct 19, 2019

It seems the fix was commit 883f8a0
and I was able to reproduce the unreproducibilty of plain 0.20
and adding the patch ontop made it reproducible in the openSUSE reproducible-builds context. We are not varying all things Debian does, so further issues could be found there later, but it is a good sign.

@jpgrayson

This comment has been minimized.

Copy link
Collaborator

jpgrayson commented Oct 21, 2019

@bmwiedemann, thank you for this feedback. This provides some motivation to cut a stgit 0.21 release soon, so that we will have a reproducible (hopefully) version of stgit out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.