Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Adding the date to the routes annotation is not helping #136

Closed
pupeno opened this Issue · 7 comments

5 participants

@pupeno

We annotate all our models and the routes files using this gem and it's very useful, but having the date in the routes file is causing us some trouble. I'm referring to:

#== Route Map
# Generated on 13 Aug 2013 12:43

many times, more than one developer runs annotate and the merge would have been uneventful because either we added different actions/controllers or the result of annotating is the same for both; except for the date and time. That date and time is the reason why many of our merges fail.

Obviously it's not a big deal, doing the manual merge is trivial, but it generates noise. Now we have many merge commits which are just one comment line in difference and that's make it harder to spot the real merge commits, those dealing with actual functional conflicts.

Furthermore, the information provided in that comment is not essential. We don't need to know exactly the date and time when the routes was annotated, and if we need to know when the file changed last, we have source control that provides us with a lot of information.

I would recommend removing it all together; but if some people find it useful, I'd like to at least have an option to remove it.

@dmagliola

This is also a problem in my team, I'd love to see this changed!

@alexch
Collaborator
@ctran ctran was assigned
@pkuczynski

+1 on that. very annoying when annotate run via guard_annotate, which cause endless test execution (unless I remove routes.rb from watch list, which is not ideal either)

@ctran ctran modified the milestone: 2.6.2, 2.7.0, 2.6.3
@ctran ctran referenced this issue from a commit
Cuong Tran Add an option to exclude timestamp in routes, #136 1243fd8
@ctran
Owner

Checkout the develop branch for the new option "-no-timestamp".

@ctran ctran closed this
@ctran ctran referenced this issue from a commit
Cuong Tran Add an option to exclude timestamp in routes, #136 d93ca72
@pkuczynski

Could this be a default behaviour with an option to turn timestamp on?

@ctran ctran referenced this issue from a commit
Cuong Tran Add an option to exclude timestamp in routes, #136 67fd10c
@alexch
Collaborator
@ctran
Owner

Sure, I'll make the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.