Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

support active model serializers #148

Closed
simonweil opened this Issue Nov 12, 2013 · 10 comments

Comments

Projects
None yet
4 participants

Please add support for Active Model Serializers Gem.
https://github.com/rails-api/active_model_serializers

Owner

ctran commented Nov 30, 2013

Could you provide a bit more details? A PR is even better :-)

Which details can help?

Looking at the code it seems that the right place to add this would be in "annotate_models.rb" adding a new pattern: SERIALIZER_PATTERNS and an exclusion option for serializers.

Is this the correct direction?

Owner

ctran commented Feb 26, 2014

Sounds good to me.

drewda added a commit to drewda/annotate_models that referenced this issue Oct 29, 2014

+1! Now that Serializers are included by default in Rails 4, formally adding support for this would be especially desirable. Can this be revisited? Our team would love it.

@drewda's fork appears to have support for this, so AFAIK it should be as simple as pulling in his fork and fixing any borked regressions.

drewda commented Feb 14, 2015

My PR is features complete, but I didn't add any test coverage. Help from
someone more familiar with the test suite would be great.
On Feb 13, 2015 3:39 PM, "Andy Rusterholz" notifications@github.com wrote:

+1! Now that Serializers are included by default in Rails 4, formally
adding support for this would be especially desirable. Can this be
revisited? Our team would love it.

@drewda https://github.com/drewda's fork appears to have support for
this, so AFAIK it should be as simple as pulling in his fork and fixing any
borked regressions.


Reply to this email directly or view it on GitHub
#148 (comment)
.

@ctran It's been over a year since this issue was opened, and almost five months since @drewda's PR. Could that be merged?

Owner

ctran commented Mar 28, 2015

I don't remember there was a PR on this.

drewda commented Apr 10, 2015

Two duplicate PRs:

In any case, there's now support for serializers.

Owner

ctran commented Apr 10, 2015

Cool!

@ctran ctran closed this Apr 10, 2015

Great, thanks!

@ctran ctran added this to the v2.6.9 milestone Apr 13, 2015

@ctran ctran self-assigned this Apr 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment