Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Annotate.load_tasks from the install generated rake file does not load the rake file that extends db:migrate #155

Closed
bughit opened this Issue · 16 comments

7 participants

bughit Mathieu Allaire Ivan Vega Cuong Tran Chad McGimpsey Anthony Collini Dmitry Bobylev
bughit

it loads /lib/tasks/*.rake

the db:migrate stuff is in /tasks/migrate.rake

Mathieu Allaire

Rake db: hooks are not working for me neither.

Ivan Vega

I fixed that on my fork, just move the migrate.rake file.

Cuong Tran
Owner
Ivan Vega

Sure, I will have to clean it up as I included two fixes in one commit. Can't test it though, because I don't use rvm so I can't run some of the tests.

Chad McGimpsey

What is the status on this fix?

Ivan Vega

I forgot about this, hehe, I just made the pull request.

Cuong Tran ctran added the bug label
Cuong Tran ctran added this to the 2.6.2 milestone
Cuong Tran ctran closed this
bughit

has this been addressed in 2.6.2?

Cuong Tran
Owner

I thought this PR #164 took care off this. Maybe I misunderstood?

Cuong Tran ctran reopened this
Cuong Tran ctran modified the milestone: 2.6.3, 2.6.2
bughit

It looks like like it didn't make it into 2.6.2

Dmitry Bobylev

@ctran seems that you did something wrong with tags?

Latest 2.6.2 tag points to old commit da8100a
@ctran released this 3 months ago · 0 commits to release/2.6.0 since this release

It should point 52181b3 as far as i understand.

Dmitry Bobylev

@ctran though git tags are messed, there is correct source version in RubyGems and rake task runs fine.

Dmitry Bobylev

@bughit in load_task method all rake tasks from tasks folder are loaded.

Cuong Tran
Owner

@dmitrybobylev Thanks for pointing this out. Looks like the tag was incorrectly created.

@bughit I assume then this is not a problem anymore?

bughit

yes, 2.6.2 is ok, thanks

Cuong Tran ctran closed this
Cuong Tran ctran modified the milestone: 2.6.2, 2.6.3
Cuong Tran ctran self-assigned this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.