Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow annotate to work with Jets, at least for models #626

Open
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
2 participants
@tongueroo
Copy link

commented May 30, 2019

Allows annotate to work with models for Jets. It won't work for Jets routes though.

Context: https://community.rubyonjets.com/t/using-annotate-with-jets/184

@drwl

This comment has been minimized.

Copy link
Collaborator

commented Jun 19, 2019

@tongueroo could you add a bit more context onto what Jets is and how this would help?

@tongueroo

This comment has been minimized.

Copy link
Author

commented Jun 19, 2019

Sure. Jets is a Ruby Serverless Framework https://rubyonjets.com/ It supports ActiveRecord so that's why someone was wanting to use annotate with it. The changes only work for models, so understand if it doesn't suffice.

@drwl

This comment has been minimized.

Copy link
Collaborator

commented Jun 19, 2019

I don't see why this gem couldn't support Jet. In its current implementation there aren't any tests or documentation on it in the README. Would it be possible to add either of these?

Also, what are your thoughts on adding a flag to invoke annotate for Jet models. Perhaps something like --jet-models?

cc @ctran if you have any objections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.