Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getSourceType api #1470

Merged
merged 1 commit into from Sep 16, 2018
Merged

Conversation

nobodyiam
Copy link
Member

to indicate where the config is loaded from, e.g. remote config service, local cache or failed

@codecov-io
Copy link

codecov-io commented Sep 12, 2018

Codecov Report

Merging #1470 into master will increase coverage by 0.18%.
The diff coverage is 94.87%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1470      +/-   ##
============================================
+ Coverage      48.4%   48.59%   +0.18%     
- Complexity     1801     1812      +11     
============================================
  Files           379      380       +1     
  Lines         10930    10956      +26     
  Branches       1121     1122       +1     
============================================
+ Hits           5291     5324      +33     
+ Misses         5253     5245       -8     
- Partials        386      387       +1
Impacted Files Coverage Δ Complexity Δ
...rk/apollo/internals/LocalFileConfigRepository.java 70.06% <100%> (+0.83%) 25 <4> (+1) ⬆️
...trip/framework/apollo/internals/DefaultConfig.java 81.44% <100%> (+2.32%) 29 <4> (+3) ⬆️
...ework/apollo/internals/RemoteConfigRepository.java 87.26% <100%> (+0.08%) 22 <1> (+1) ⬆️
...ctrip/framework/apollo/internals/SimpleConfig.java 87.17% <100%> (+1.46%) 8 <4> (+2) ⬆️
...ctrip/framework/apollo/enums/ConfigSourceType.java 83.33% <83.33%> (ø) 2 <2> (?)
...framework/apollo/internals/AbstractConfigFile.java 86.2% <83.33%> (-0.59%) 11 <2> (+1)
...ervice/service/ReleaseMessageServiceWithCache.java 85.71% <0%> (-1.2%) 24% <0%> (-1%)
...lo/configservice/util/InstanceConfigAuditUtil.java 70.17% <0%> (-0.88%) 13% <0%> (-1%)
...rip/framework/apollo/internals/AbstractConfig.java 81.85% <0%> (+0.84%) 50% <0%> (+1%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 976b69d...b2c0692. Read the comment docs.

@coveralls
Copy link

coveralls commented Sep 12, 2018

Coverage Status

Coverage increased (+0.1%) to 52.127% when pulling 17236f1 on nobodyiam:config-source into ffc99dd on ctripcorp:master.

@nobodyiam nobodyiam merged commit 9e3aec5 into apolloconfig:master Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants