New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testcase broken by search.cpan.org shutdown #1

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
1 participant
@HaraldJoerg

HaraldJoerg commented Aug 1, 2018

This Pull Request is motivated by the CPAN Pull Request Challenge (http://cpan-prc.org/) where I got the distribution Test::VCR::LWP as my assignment for August.

Recent CPAN Testers reports at http://www.cpantesters.org/distro/T/Test-VCR-LWP.html show a failure in the tests, which is easily reproduced, and easily fixed.

Test #30 fails with Failed test 'bar.tape contents do not match regex'. The test fetches the apple website and search.cpan.org and checks that the apple website is not recorded by asserting that the string "apple" is not in the recording. But, as of recently, search.cpan.org redirects to metacpan.org, and this website unfortunately has the string "apple" in its apple-touch-icon metadata.

Just making the assertion a bit more specific - checking for apple.com instead of apple - fixes the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment