feat: support property data #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a problem with the Gemini CLI PR review. Please check the action logs for details. |
src/test/kotlin/com/ctrlhub/core/projects/operations/OperationsRouterTest.kt
Show resolved
Hide resolved
andrew-waters
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request extends the data model for properties and adds comprehensive test coverage for retrieving operations with included property details. The main focus is on supporting richer property information (such as address, location, meters, PSR, and UPRN) and ensuring these fields are correctly handled when included in API responses.
Data model enhancements:
Propertydata class to include new fields:address,location,meters,psr, anduprn, and introduced new supporting data classes (Address,Location,BritishNationalGrid,LatLong,Psr, andMeter) to represent these details.Test coverage improvements:
OperationsRouterTestto verify that operations can be retrieved with included property details, and that all new fields (address, location, meters, PSR, UPRN) are correctly deserialized and validated.