Fix a failing JS test#354
Merged
Merged
Conversation
cigamit
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a flaky failing ScheduleForm unit test in the AWX UI that broke after the recent redesign by deriving the end date/time from the rendered start date/time instead of using DateTime.now() and new Date(<yyyy-mm-dd>).
Changes:
- Read the rendered Start date and Start time values from the form and compute an end time slightly later.
- Pass a JS
Datecreated via Luxon parsing (matching the provided date string) to the DatePickeronChange, avoiding timezone-dependent parsing.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TheWitness
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test was failing from the recent redesign.