Skip to content

Commit 08cbc75

Browse files
nathanchancedavem330
authored andcommitted
ppp: Adjust indentation into ppp_async_input
Clang warns: ../drivers/net/ppp/ppp_async.c:877:6: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] ap->rpkt = skb; ^ ../drivers/net/ppp/ppp_async.c:875:5: note: previous statement is here if (!skb) ^ 1 warning generated. This warning occurs because there is a space before the tab on this line. Clean up this entire block's indentation so that it is consistent with the Linux kernel coding style and clang no longer warns. Fixes: 6722e78 ("[PPP]: handle misaligned accesses") Link: ClangBuiltLinux/linux#800 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 5c61e22 commit 08cbc75

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

drivers/net/ppp/ppp_async.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -874,15 +874,15 @@ ppp_async_input(struct asyncppp *ap, const unsigned char *buf,
874874
skb = dev_alloc_skb(ap->mru + PPP_HDRLEN + 2);
875875
if (!skb)
876876
goto nomem;
877-
ap->rpkt = skb;
878-
}
879-
if (skb->len == 0) {
880-
/* Try to get the payload 4-byte aligned.
881-
* This should match the
882-
* PPP_ALLSTATIONS/PPP_UI/compressed tests in
883-
* process_input_packet, but we do not have
884-
* enough chars here to test buf[1] and buf[2].
885-
*/
877+
ap->rpkt = skb;
878+
}
879+
if (skb->len == 0) {
880+
/* Try to get the payload 4-byte aligned.
881+
* This should match the
882+
* PPP_ALLSTATIONS/PPP_UI/compressed tests in
883+
* process_input_packet, but we do not have
884+
* enough chars here to test buf[1] and buf[2].
885+
*/
886886
if (buf[0] != PPP_ALLSTATIONS)
887887
skb_reserve(skb, 2 + (buf[0] & 1));
888888
}

0 commit comments

Comments
 (0)