mptcp: fix uninit-value in mptcp_incoming_options

ea1davis · davem330 · commit 237ff253f2d4 · 2023-11-24T14:58:33.000Z
Added initialization use_ack to mptcp_parse_option().

Reported-by: syzbot+b834a6b2decad004cfa1@syzkaller.appspotmail.com
Signed-off-by: Edward Adam Davis &lt;eadavis@qq.com&gt;
Acked-by: Paolo Abeni &lt;pabeni@redhat.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/mptcp/options.c b/net/mptcp/options.c
@@ -108,6 +108,7 @@ static void mptcp_parse_option(const struct sk_buff *skb,
 			mp_opt->suboptions |= OPTION_MPTCP_DSS;
 			mp_opt->use_map = 1;
 			mp_opt->mpc_map = 1;
+			mp_opt->use_ack = 0;
 			mp_opt->data_len = get_unaligned_be16(ptr);
 			ptr += 2;
 		}

Original file line number	Diff line number	Diff line change
`@@ -108,6 +108,7 @@ static void mptcp_parse_option(const struct sk_buff *skb,`
`108`	`108`	`mp_opt->suboptions \|= OPTION_MPTCP_DSS;`
`109`	`109`	`mp_opt->use_map = 1;`
`110`	`110`	`mp_opt->mpc_map = 1;`
	`111`	`+ mp_opt->use_ack = 0;`
`111`	`112`	`mp_opt->data_len = get_unaligned_be16(ptr);`
`112`	`113`	`ptr += 2;`
`113`	`114`	`}`