Skip to content

Commit 2b6ab0d

Browse files
jrfastabdavem330
authored andcommitted
net: cls_u32: move TC offload feature bit into cls_u32 offload logic
In the original series drivers would get offload requests for cls_u32 rules even if the feature bit is disabled. This meant the driver had to do a boiler plate check on the feature bit before adding/deleting the rule. This patch lifts the check into the core code and removes it from the driver specific case. Signed-off-by: John Fastabend <john.r.fastabend@intel.com> Acked-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 6843e7a commit 2b6ab0d

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8400,9 +8400,6 @@ int __ixgbe_setup_tc(struct net_device *dev, u32 handle, __be16 proto,
84008400

84018401
if (TC_H_MAJ(handle) == TC_H_MAJ(TC_H_INGRESS) &&
84028402
tc->type == TC_SETUP_CLSU32) {
8403-
if (!(dev->features & NETIF_F_HW_TC))
8404-
return -EINVAL;
8405-
84068403
switch (tc->cls_u32->command) {
84078404
case TC_CLSU32_NEW_KNODE:
84088405
case TC_CLSU32_REPLACE_KNODE:

include/net/pkt_cls.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -394,6 +394,9 @@ struct tc_cls_u32_offload {
394394

395395
static inline bool tc_should_offload(struct net_device *dev)
396396
{
397+
if (!(dev->features & NETIF_F_HW_TC))
398+
return false;
399+
397400
return dev->netdev_ops->ndo_setup_tc;
398401
}
399402

0 commit comments

Comments
 (0)