Commit 2c6d963
committed
Revert "Makefile: install modules.builtin even if CONFIG_MODULES=n"
This reverts commit e0b250b,
which broke build systems that need to install files to a certain
path, but do not set INSTALL_MOD_PATH when invoking 'make install'.
$ make INSTALL_PATH=/tmp/destdir install
mkdir: cannot create directory ‘/lib/modules/5.8.0-rc1+/’: Permission denied
Makefile:1342: recipe for target '_builtin_inst_' failed
make: *** [_builtin_inst_] Error 1
While modules.builtin is useful also for CONFIG_MODULES=n, this change
in the behavior is quite unexpected. Maybe "make modules_install"
can install modules.builtin irrespective of CONFIG_MODULES as Jonas
originally suggested.
Anyway, that commit should be reverted ASAP.
Reported-by: Douglas Anderson <dianders@chromium.org>
Reported-by: Guenter Roeck <linux@roeck-us.net>
Cc: Jonas Karlman <jonas@kwiboo.se>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Tested-by: Guenter Roeck <linux@roeck-us.net>1 parent 0f50d21 commit 2c6d963
1 file changed
+3
-11
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1336 | 1336 | | |
1337 | 1337 | | |
1338 | 1338 | | |
1339 | | - | |
1340 | | - | |
1341 | | - | |
1342 | | - | |
1343 | | - | |
1344 | | - | |
1345 | | - | |
1346 | | - | |
1347 | | - | |
1348 | | - | |
1349 | 1339 | | |
1350 | 1340 | | |
1351 | 1341 | | |
| |||
1389 | 1379 | | |
1390 | 1380 | | |
1391 | 1381 | | |
1392 | | - | |
| 1382 | + | |
1393 | 1383 | | |
1394 | 1384 | | |
1395 | 1385 | | |
| |||
1399 | 1389 | | |
1400 | 1390 | | |
1401 | 1391 | | |
| 1392 | + | |
| 1393 | + | |
1402 | 1394 | | |
1403 | 1395 | | |
1404 | 1396 | | |
| |||
0 commit comments