Skip to content

Commit 44b911e

Browse files
Jack Morgensteindavem330
authored andcommitted
net/mlx4: Fix uninitialized fields in rule when adding promiscuous mode to device managed flow steering
In procedure mlx4_flow_steer_promisc_add(), several fields were left uninitialized in the rule structure. Correctly initialize these fields. Fixes: 592e49d ("net/mlx4: Implement promiscuous mode with device managed flow-steering") Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il> Signed-off-by: Tariq Toukan <tariqt@mellanox.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent b435370 commit 44b911e

File tree

1 file changed

+6
-1
lines changed
  • drivers/net/ethernet/mellanox/mlx4

1 file changed

+6
-1
lines changed

drivers/net/ethernet/mellanox/mlx4/mcg.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1457,7 +1457,12 @@ EXPORT_SYMBOL_GPL(mlx4_multicast_detach);
14571457
int mlx4_flow_steer_promisc_add(struct mlx4_dev *dev, u8 port,
14581458
u32 qpn, enum mlx4_net_trans_promisc_mode mode)
14591459
{
1460-
struct mlx4_net_trans_rule rule;
1460+
struct mlx4_net_trans_rule rule = {
1461+
.queue_mode = MLX4_NET_TRANS_Q_FIFO,
1462+
.exclusive = 0,
1463+
.allow_loopback = 1,
1464+
};
1465+
14611466
u64 *regid_p;
14621467

14631468
switch (mode) {

0 commit comments

Comments
 (0)