Skip to content

Commit 5b4bc44

Browse files
committed
powerpc: Stop using no_llseek
Since commit 868941b ("fs: remove no_llseek"), no_llseek() is simply defined to be NULL, and a NULL llseek means seeking is unsupported. So for statically defined file_operations, such as all these, there's no need or benefit to set llseek = no_llseek. Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://msgid.link/20240903111951.141376-1-mpe@ellerman.id.au
1 parent 29dbb98 commit 5b4bc44

File tree

5 files changed

+0
-24
lines changed

5 files changed

+0
-24
lines changed

arch/powerpc/kernel/eeh.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1682,7 +1682,6 @@ static ssize_t eeh_force_recover_write(struct file *filp,
16821682

16831683
static const struct file_operations eeh_force_recover_fops = {
16841684
.open = simple_open,
1685-
.llseek = no_llseek,
16861685
.write = eeh_force_recover_write,
16871686
};
16881687

@@ -1726,7 +1725,6 @@ static ssize_t eeh_dev_check_write(struct file *filp,
17261725

17271726
static const struct file_operations eeh_dev_check_fops = {
17281727
.open = simple_open,
1729-
.llseek = no_llseek,
17301728
.write = eeh_dev_check_write,
17311729
.read = eeh_debugfs_dev_usage,
17321730
};
@@ -1846,7 +1844,6 @@ static ssize_t eeh_dev_break_write(struct file *filp,
18461844

18471845
static const struct file_operations eeh_dev_break_fops = {
18481846
.open = simple_open,
1849-
.llseek = no_llseek,
18501847
.write = eeh_dev_break_write,
18511848
.read = eeh_debugfs_dev_usage,
18521849
};
@@ -1893,7 +1890,6 @@ static ssize_t eeh_dev_can_recover(struct file *filp,
18931890

18941891
static const struct file_operations eeh_dev_can_recover_fops = {
18951892
.open = simple_open,
1896-
.llseek = no_llseek,
18971893
.write = eeh_dev_can_recover,
18981894
.read = eeh_debugfs_dev_usage,
18991895
};

arch/powerpc/platforms/52xx/mpc52xx_gpt.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -644,7 +644,6 @@ static int mpc52xx_wdt_release(struct inode *inode, struct file *file)
644644

645645
static const struct file_operations mpc52xx_wdt_fops = {
646646
.owner = THIS_MODULE,
647-
.llseek = no_llseek,
648647
.write = mpc52xx_wdt_write,
649648
.unlocked_ioctl = mpc52xx_wdt_ioctl,
650649
.compat_ioctl = compat_ptr_ioctl,

arch/powerpc/platforms/cell/spufs/file.c

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,6 @@ static const struct file_operations spufs_cntl_fops = {
453453
.release = spufs_cntl_release,
454454
.read = simple_attr_read,
455455
.write = simple_attr_write,
456-
.llseek = no_llseek,
457456
.mmap = spufs_cntl_mmap,
458457
};
459458

@@ -634,7 +633,6 @@ static ssize_t spufs_mbox_read(struct file *file, char __user *buf,
634633
static const struct file_operations spufs_mbox_fops = {
635634
.open = spufs_pipe_open,
636635
.read = spufs_mbox_read,
637-
.llseek = no_llseek,
638636
};
639637

640638
static ssize_t spufs_mbox_stat_read(struct file *file, char __user *buf,
@@ -664,7 +662,6 @@ static ssize_t spufs_mbox_stat_read(struct file *file, char __user *buf,
664662
static const struct file_operations spufs_mbox_stat_fops = {
665663
.open = spufs_pipe_open,
666664
.read = spufs_mbox_stat_read,
667-
.llseek = no_llseek,
668665
};
669666

670667
/* low-level ibox access function */
@@ -769,7 +766,6 @@ static const struct file_operations spufs_ibox_fops = {
769766
.open = spufs_pipe_open,
770767
.read = spufs_ibox_read,
771768
.poll = spufs_ibox_poll,
772-
.llseek = no_llseek,
773769
};
774770

775771
static ssize_t spufs_ibox_stat_read(struct file *file, char __user *buf,
@@ -797,7 +793,6 @@ static ssize_t spufs_ibox_stat_read(struct file *file, char __user *buf,
797793
static const struct file_operations spufs_ibox_stat_fops = {
798794
.open = spufs_pipe_open,
799795
.read = spufs_ibox_stat_read,
800-
.llseek = no_llseek,
801796
};
802797

803798
/* low-level mailbox write */
@@ -901,7 +896,6 @@ static const struct file_operations spufs_wbox_fops = {
901896
.open = spufs_pipe_open,
902897
.write = spufs_wbox_write,
903898
.poll = spufs_wbox_poll,
904-
.llseek = no_llseek,
905899
};
906900

907901
static ssize_t spufs_wbox_stat_read(struct file *file, char __user *buf,
@@ -929,7 +923,6 @@ static ssize_t spufs_wbox_stat_read(struct file *file, char __user *buf,
929923
static const struct file_operations spufs_wbox_stat_fops = {
930924
.open = spufs_pipe_open,
931925
.read = spufs_wbox_stat_read,
932-
.llseek = no_llseek,
933926
};
934927

935928
static int spufs_signal1_open(struct inode *inode, struct file *file)
@@ -1056,15 +1049,13 @@ static const struct file_operations spufs_signal1_fops = {
10561049
.read = spufs_signal1_read,
10571050
.write = spufs_signal1_write,
10581051
.mmap = spufs_signal1_mmap,
1059-
.llseek = no_llseek,
10601052
};
10611053

10621054
static const struct file_operations spufs_signal1_nosched_fops = {
10631055
.open = spufs_signal1_open,
10641056
.release = spufs_signal1_release,
10651057
.write = spufs_signal1_write,
10661058
.mmap = spufs_signal1_mmap,
1067-
.llseek = no_llseek,
10681059
};
10691060

10701061
static int spufs_signal2_open(struct inode *inode, struct file *file)
@@ -1195,15 +1186,13 @@ static const struct file_operations spufs_signal2_fops = {
11951186
.read = spufs_signal2_read,
11961187
.write = spufs_signal2_write,
11971188
.mmap = spufs_signal2_mmap,
1198-
.llseek = no_llseek,
11991189
};
12001190

12011191
static const struct file_operations spufs_signal2_nosched_fops = {
12021192
.open = spufs_signal2_open,
12031193
.release = spufs_signal2_release,
12041194
.write = spufs_signal2_write,
12051195
.mmap = spufs_signal2_mmap,
1206-
.llseek = no_llseek,
12071196
};
12081197

12091198
/*
@@ -1343,7 +1332,6 @@ static const struct file_operations spufs_mss_fops = {
13431332
.open = spufs_mss_open,
13441333
.release = spufs_mss_release,
13451334
.mmap = spufs_mss_mmap,
1346-
.llseek = no_llseek,
13471335
};
13481336

13491337
static vm_fault_t
@@ -1401,7 +1389,6 @@ static const struct file_operations spufs_psmap_fops = {
14011389
.open = spufs_psmap_open,
14021390
.release = spufs_psmap_release,
14031391
.mmap = spufs_psmap_mmap,
1404-
.llseek = no_llseek,
14051392
};
14061393

14071394

@@ -1732,7 +1719,6 @@ static const struct file_operations spufs_mfc_fops = {
17321719
.flush = spufs_mfc_flush,
17331720
.fsync = spufs_mfc_fsync,
17341721
.mmap = spufs_mfc_mmap,
1735-
.llseek = no_llseek,
17361722
};
17371723

17381724
static int spufs_npc_set(void *data, u64 val)
@@ -2102,7 +2088,6 @@ static ssize_t spufs_dma_info_read(struct file *file, char __user *buf,
21022088
static const struct file_operations spufs_dma_info_fops = {
21032089
.open = spufs_info_open,
21042090
.read = spufs_dma_info_read,
2105-
.llseek = no_llseek,
21062091
};
21072092

21082093
static void spufs_get_proxydma_info(struct spu_context *ctx,
@@ -2159,7 +2144,6 @@ static ssize_t spufs_proxydma_info_read(struct file *file, char __user *buf,
21592144
static const struct file_operations spufs_proxydma_info_fops = {
21602145
.open = spufs_info_open,
21612146
.read = spufs_proxydma_info_read,
2162-
.llseek = no_llseek,
21632147
};
21642148

21652149
static int spufs_show_tid(struct seq_file *s, void *private)
@@ -2442,7 +2426,6 @@ static const struct file_operations spufs_switch_log_fops = {
24422426
.read = spufs_switch_log_read,
24432427
.poll = spufs_switch_log_poll,
24442428
.release = spufs_switch_log_release,
2445-
.llseek = no_llseek,
24462429
};
24472430

24482431
/**

arch/powerpc/platforms/powernv/eeh-powernv.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ static ssize_t pnv_eeh_ei_write(struct file *filp,
9999

100100
static const struct file_operations pnv_eeh_ei_fops = {
101101
.open = simple_open,
102-
.llseek = no_llseek,
103102
.write = pnv_eeh_ei_write,
104103
};
105104

arch/powerpc/platforms/pseries/dtl.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,6 @@ static const struct file_operations dtl_fops = {
325325
.open = dtl_file_open,
326326
.release = dtl_file_release,
327327
.read = dtl_file_read,
328-
.llseek = no_llseek,
329328
};
330329

331330
static struct dentry *dtl_dir;

0 commit comments

Comments
 (0)