Skip to content

Commit 71e0cc1

Browse files
gcabidduherbertx
authored andcommitted
crypto: qat - add shutdown handler to qat_c3xxx
During a warm reset via kexec, the system bypasses the driver removal sequence, meaning that the remove() callback is not invoked. If a QAT device is not shutdown properly, the device driver will fail to load in a newly rebooted kernel. This might result in output like the following after the kexec reboot: QAT: AE0 is inactive!! QAT: failed to get device out of reset c3xxx 0000:3f:00.0: qat_hal_clr_reset error c3xxx 0000:3f:00.0: Failed to init the AEs c3xxx 0000:3f:00.0: Failed to initialise Acceleration Engine c3xxx 0000:3f:00.0: Resetting device qat_dev0 c3xxx 0000:3f:00.0: probe with driver c3xxx failed with error -14 Implement the shutdown() handler that hooks into the reboot notifier list. This brings down the QAT device and ensures it is shut down properly. Cc: <stable@vger.kernel.org> Fixes: 890c55f ("crypto: qat - add support for c3xxx accel type") Reviewed-by: Ahsan Atta <ahsan.atta@intel.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
1 parent 4fc54f6 commit 71e0cc1

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

drivers/crypto/intel/qat/qat_c3xxx/adf_drv.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -209,6 +209,13 @@ static void adf_remove(struct pci_dev *pdev)
209209
kfree(accel_dev);
210210
}
211211

212+
static void adf_shutdown(struct pci_dev *pdev)
213+
{
214+
struct adf_accel_dev *accel_dev = adf_devmgr_pci_to_accel_dev(pdev);
215+
216+
adf_dev_down(accel_dev);
217+
}
218+
212219
static const struct pci_device_id adf_pci_tbl[] = {
213220
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_QAT_C3XXX) },
214221
{ }
@@ -220,6 +227,7 @@ static struct pci_driver adf_driver = {
220227
.name = ADF_C3XXX_DEVICE_NAME,
221228
.probe = adf_probe,
222229
.remove = adf_remove,
230+
.shutdown = adf_shutdown,
223231
.sriov_configure = adf_sriov_configure,
224232
.err_handler = &adf_err_handler,
225233
};

0 commit comments

Comments
 (0)