Skip to content

Commit 7a89334

Browse files
committed
drm/xe/guc: Move ARAT interrupts enabling to the upload step
Even though ARAT interrupts are enabled by default, we still want to keep the code that enables them. But instead doing that in the CTB enabling step, move this code to the upload step, where we already setup few other registers related to GuC. Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com> Cc: Matthew Brost <matthew.brost@intel.com> Reviewed-by: Matthew Brost <matthew.brost@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240619163413.817-1-michal.wajdeczko@intel.com
1 parent 8e7455d commit 7a89334

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/gpu/drm/xe/xe_guc.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -476,6 +476,9 @@ static void guc_prepare_xfer(struct xe_guc *guc)
476476
xe_mmio_write32(gt, GUC_SHIM_CONTROL, shim_flags);
477477

478478
xe_mmio_write32(gt, GT_PM_CONFIG, GT_DOORBELL_ENABLE);
479+
480+
/* Make sure GuC receives ARAT interrupts */
481+
xe_mmio_rmw32(gt, PMINTRMSK, ARAT_EXPIRED_INTRMSK, 0);
479482
}
480483

481484
/*
@@ -865,9 +868,6 @@ int xe_guc_enable_communication(struct xe_guc *guc)
865868
guc_enable_irq(guc);
866869
}
867870

868-
xe_mmio_rmw32(guc_to_gt(guc), PMINTRMSK,
869-
ARAT_EXPIRED_INTRMSK, 0);
870-
871871
err = xe_guc_ct_enable(&guc->ct);
872872
if (err)
873873
return err;

0 commit comments

Comments
 (0)