Skip to content

Commit 7c81047

Browse files
Michael Chandavem330
authored andcommitted
bnx2: Always set ETH_FLAG_TXVLAN
TSO does not work if the VLAN tag is in the packet (non-accelerated). We may be able to remove this restriction in future firmware. Reported-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: Michael Chan <mchan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent b7c7d01 commit 7c81047

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

drivers/net/bnx2.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7553,6 +7553,10 @@ bnx2_set_flags(struct net_device *dev, u32 data)
75537553
!(data & ETH_FLAG_RXVLAN))
75547554
return -EINVAL;
75557555

7556+
/* TSO with VLAN tag won't work with current firmware */
7557+
if (!(data & ETH_FLAG_TXVLAN))
7558+
return -EINVAL;
7559+
75567560
rc = ethtool_op_set_flags(dev, data, ETH_FLAG_RXHASH | ETH_FLAG_RXVLAN |
75577561
ETH_FLAG_TXVLAN);
75587562
if (rc)

0 commit comments

Comments
 (0)