Skip to content

Commit 82ea174

Browse files
StanFox1984Manasi Navare
authored andcommitted
drm/i915: Remove unneeded hack now for CDCLK
No need to bump up CDCLK now, as it is now correctly calculated, accounting for DBuf BW as BSpec says. Reviewed-by: Manasi Navare <manasi.d.navare@intel.com> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20200519131117.17190-8-stanislav.lisovskiy@intel.com
1 parent cd19154 commit 82ea174

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

drivers/gpu/drm/i915/display/intel_cdclk.c

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2070,18 +2070,6 @@ int intel_crtc_compute_min_cdclk(const struct intel_crtc_state *crtc_state)
20702070
/* Account for additional needs from the planes */
20712071
min_cdclk = max(intel_planes_min_cdclk(crtc_state), min_cdclk);
20722072

2073-
/*
2074-
* HACK. Currently for TGL platforms we calculate
2075-
* min_cdclk initially based on pixel_rate divided
2076-
* by 2, accounting for also plane requirements,
2077-
* however in some cases the lowest possible CDCLK
2078-
* doesn't work and causing the underruns.
2079-
* Explicitly stating here that this seems to be currently
2080-
* rather a Hack, than final solution.
2081-
*/
2082-
if (IS_TIGERLAKE(dev_priv))
2083-
min_cdclk = max(min_cdclk, (int)crtc_state->pixel_rate);
2084-
20852073
if (min_cdclk > dev_priv->max_cdclk_freq) {
20862074
drm_dbg_kms(&dev_priv->drm,
20872075
"required cdclk (%d kHz) exceeds max (%d kHz)\n",

0 commit comments

Comments
 (0)