bnxt_en: Fix active FEC reporting to ethtool

skotur-brcm · davem330 · commit 84d3c83e6ea7 · 2022-02-20T13:47:14.000Z
ethtool --show-fec <interface> does not show anything when the Active FEC setting in the chip is set to None. Fix it to properly return ETHTOOL_FEC_OFF in that case. Fixes: 8b27758 ("bnxt_en: Report FEC settings to ethtool.") Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com> Signed-off-by: Michael Chan <michael.chan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
@@ -1969,6 +1969,9 @@ static int bnxt_get_fecparam(struct net_device *dev,
 	case PORT_PHY_QCFG_RESP_ACTIVE_FEC_FEC_RS272_IEEE_ACTIVE:
 		fec->active_fec |= ETHTOOL_FEC_LLRS;
 		break;
+	case PORT_PHY_QCFG_RESP_ACTIVE_FEC_FEC_NONE_ACTIVE:
+		fec->active_fec |= ETHTOOL_FEC_OFF;
+		break;
 	}
 	return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -1969,6 +1969,9 @@ static int bnxt_get_fecparam(struct net_device *dev,`
`1969`	`1969`	`case PORT_PHY_QCFG_RESP_ACTIVE_FEC_FEC_RS272_IEEE_ACTIVE:`
`1970`	`1970`	`fec->active_fec \|= ETHTOOL_FEC_LLRS;`
`1971`	`1971`	`break;`
	`1972`	`+ case PORT_PHY_QCFG_RESP_ACTIVE_FEC_FEC_NONE_ACTIVE:`
	`1973`	`+ fec->active_fec \|= ETHTOOL_FEC_OFF;`
	`1974`	`+ break;`
`1972`	`1975`	`}`
`1973`	`1976`	`return 0;`
`1974`	`1977`	`}`