Skip to content

Commit 86d4647

Browse files
author
Kent Overstreet
committed
bcachefs: Don't block journal when finishing check_allocations()
Blocking the journal was needed to finish checking old style accounting, but that code is gone and it's not needed in the alloc rewrite, mark_lock is sufficient for synchronization. Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
1 parent 5645c32 commit 86d4647

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

fs/bcachefs/btree_gc.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1142,15 +1142,11 @@ int bch2_check_allocations(struct bch_fs *c)
11421142

11431143
c->gc_count++;
11441144

1145-
bch2_journal_block(&c->journal);
1146-
out:
11471145
ret = bch2_gc_alloc_done(c) ?:
11481146
bch2_accounting_gc_done(c) ?:
11491147
bch2_gc_stripes_done(c) ?:
11501148
bch2_gc_reflink_done(c);
1151-
1152-
bch2_journal_unblock(&c->journal);
1153-
1149+
out:
11541150
percpu_down_write(&c->mark_lock);
11551151
/* Indicates that gc is no longer in progress: */
11561152
__gc_pos_set(c, gc_phase(GC_PHASE_not_running));

0 commit comments

Comments
 (0)