wan: lmc: remove unnecessary pci_set_drvdata()

Jingoo Han · davem330 · commit 94d6b538c7d2 · 2013-12-09T18:09:29.000-05:00
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han &lt;jg1.han@samsung.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c
@@ -973,7 +973,6 @@ static int lmc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
     return 0;
 
 err_hdlcdev:
-	pci_set_drvdata(pdev, NULL);
 	kfree(sc);
 err_kzalloc:
 	pci_release_regions(pdev);
@@ -995,7 +994,6 @@ static void lmc_remove_one(struct pci_dev *pdev)
 		free_netdev(dev);
 		pci_release_regions(pdev);
 		pci_disable_device(pdev);
-		pci_set_drvdata(pdev, NULL);
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -973,7 +973,6 @@ static int lmc_init_one(struct pci_dev pdev, const struct pci_device_id ent)`
`973`	`973`	`return 0;`
`974`	`974`
`975`	`975`	`err_hdlcdev:`
`976`		`- pci_set_drvdata(pdev, NULL);`
`977`	`976`	`kfree(sc);`
`978`	`977`	`err_kzalloc:`
`979`	`978`	`pci_release_regions(pdev);`
`@@ -995,7 +994,6 @@ static void lmc_remove_one(struct pci_dev *pdev)`
`995`	`994`	`free_netdev(dev);`
`996`	`995`	`pci_release_regions(pdev);`
`997`	`996`	`pci_disable_device(pdev);`
`998`		`- pci_set_drvdata(pdev, NULL);`
`999`	`997`	`}`
`1000`	`998`	`}`
`1001`	`999`