bnx2x: unlock before returning an error

Dan Carpenter · davem330 · commit a44acd551467 · 2012-01-25T16:58:26.000-05:00
We introduced a new return here but forgot to drop the lock.

Signed-off-by: Dan Carpenter &lt;dan.carpenter@oracle.com&gt;
Acked-by: Dmitry Kravkov &lt;dmitry@broadcom.com&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.c
@@ -1836,6 +1836,7 @@ static int bnx2x_vlan_mac_del_all(struct bnx2x *bp,
 			rc = exeq->remove(bp, exeq->owner, exeq_pos);
 			if (rc) {
 				BNX2X_ERR("Failed to remove command\n");
+				spin_unlock_bh(&exeq->lock);
 				return rc;
 			}
 			list_del(&exeq_pos->link);

Original file line number	Diff line number	Diff line change
`@@ -1836,6 +1836,7 @@ static int bnx2x_vlan_mac_del_all(struct bnx2x *bp,`
`1836`	`1836`	`rc = exeq->remove(bp, exeq->owner, exeq_pos);`
`1837`	`1837`	`if (rc) {`
`1838`	`1838`	`BNX2X_ERR("Failed to remove command\n");`
	`1839`	`+ spin_unlock_bh(&exeq->lock);`
`1839`	`1840`	`return rc;`
`1840`	`1841`	`}`
`1841`	`1842`	`list_del(&exeq_pos->link);`