Skip to content

Commit aea62c7

Browse files
baekseunghwan8267storulf
authored andcommitted
mmc: cqhci: Fix checking of CQHCI_HALT state
To check if mmc cqe is in halt state, need to check set/clear of CQHCI_HALT bit. At this time, we need to check with &, not &&. Fixes: a408022 ("mmc: cqhci: support for command queue enabled host") Cc: stable@vger.kernel.org Signed-off-by: Seunghwan Baek <sh8267.baek@samsung.com> Reviewed-by: Ritesh Harjani <ritesh.list@gmail.com> Acked-by: Adrian Hunter <adrian.hunter@intel.com> Link: https://lore.kernel.org/r/20240829061823.3718-2-sh8267.baek@samsung.com Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
1 parent 8396c79 commit aea62c7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/mmc/host/cqhci-core.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -617,7 +617,7 @@ static int cqhci_request(struct mmc_host *mmc, struct mmc_request *mrq)
617617
cqhci_writel(cq_host, 0, CQHCI_CTL);
618618
mmc->cqe_on = true;
619619
pr_debug("%s: cqhci: CQE on\n", mmc_hostname(mmc));
620-
if (cqhci_readl(cq_host, CQHCI_CTL) && CQHCI_HALT) {
620+
if (cqhci_readl(cq_host, CQHCI_CTL) & CQHCI_HALT) {
621621
pr_err("%s: cqhci: CQE failed to exit halt state\n",
622622
mmc_hostname(mmc));
623623
}

0 commit comments

Comments
 (0)