Skip to content

Commit bb5367d

Browse files
committed
drm/ast: Remove gamma LUT updates from DPMS code
The DPMS code, called from the CRTC's atomic_enable, rewrites the gamma LUT. This is already done by the CRTC's atomic_flush. Remove the duplication. v2: - fix a typo in commit message Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240627153638.8765-6-tzimmermann@suse.de
1 parent 4f3265b commit bb5367d

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

drivers/gpu/drm/ast/ast_mode.c

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1023,8 +1023,6 @@ static void ast_crtc_dpms(struct drm_crtc *crtc, int mode)
10231023
{
10241024
struct ast_device *ast = to_ast_device(crtc->dev);
10251025
u8 ch = AST_DPMS_VSYNC_OFF | AST_DPMS_HSYNC_OFF;
1026-
struct ast_crtc_state *ast_state;
1027-
const struct drm_format_info *format;
10281026

10291027
/* TODO: Maybe control display signal generation with
10301028
* Sync Enable (bit CR17.7).
@@ -1033,16 +1031,6 @@ static void ast_crtc_dpms(struct drm_crtc *crtc, int mode)
10331031
case DRM_MODE_DPMS_ON:
10341032
ast_set_index_reg_mask(ast, AST_IO_VGASRI, 0x01, 0xdf, 0);
10351033
ast_set_index_reg_mask(ast, AST_IO_VGACRI, 0xb6, 0xfc, 0);
1036-
1037-
ast_state = to_ast_crtc_state(crtc->state);
1038-
format = ast_state->format;
1039-
1040-
if (format) {
1041-
if (crtc->state->gamma_lut)
1042-
ast_crtc_set_gamma(ast, format, crtc->state->gamma_lut->data);
1043-
else
1044-
ast_crtc_set_gamma_linear(ast, format);
1045-
}
10461034
break;
10471035
case DRM_MODE_DPMS_STANDBY:
10481036
case DRM_MODE_DPMS_SUSPEND:

0 commit comments

Comments
 (0)