pmdomain: thead: Fix error pointer vs NULL bug in th1520_pd_reboot_init()

Dan Carpenter · storulf · commit bbc3110823ec · 2025-09-26T14:50:20.000+02:00
The devm_auxiliary_device_create() returns NULL on error. It never returns error pointers. Using PTR_ERR_OR_ZERO() here means the function always returns success. Replace the PTR_ERR_OR_ZERO() call check with a NULL check. Fixes: 64581f4 ("pmdomain: thead: create auxiliary device for rebooting") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Acked-by: Icenowy Zheng <uwu@icenowy.me> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
diff --git a/drivers/pmdomain/thead/th1520-pm-domains.c b/drivers/pmdomain/thead/th1520-pm-domains.c
@@ -179,8 +179,10 @@ static int th1520_pd_reboot_init(struct device *dev,
 	struct auxiliary_device *adev;
 
 	adev = devm_auxiliary_device_create(dev, "reboot", aon_chan);
+	if (!adev)
+		return -ENODEV;
 
-	return PTR_ERR_OR_ZERO(adev);
+	return 0;
 }
 
 static int th1520_pd_probe(struct platform_device *pdev)

Original file line number	Diff line number	Diff line change
`@@ -179,8 +179,10 @@ static int th1520_pd_reboot_init(struct device *dev,`
`179`	`179`	`struct auxiliary_device *adev;`
`180`	`180`
`181`	`181`	`adev = devm_auxiliary_device_create(dev, "reboot", aon_chan);`
	`182`	`+ if (!adev)`
	`183`	`+ return -ENODEV;`
`182`	`184`
`183`		`- return PTR_ERR_OR_ZERO(adev);`
	`185`	`+ return 0;`
`184`	`186`	`}`
`185`	`187`
`186`	`188`	`static int th1520_pd_probe(struct platform_device *pdev)`