Skip to content

Commit bc8befe

Browse files
author
Kalle Valo
committed
ath11k: fix undefined reference to 'ath11k_debugfs_htt_ext_stats_handler'
kbuild bot reported than link fails when CONFIG_ATH11K_DEBUGFS is disabled: drivers/net/wireless/ath/ath11k/dp_rx.c:1662: undefined reference to `ath11k_debugfs_htt_ext_stats_handler' This was because I had missed to move the static inline version of the function (which are used when CONFIG_ATH11K_DEBUGFS is disabled) to debufs_htt_stats.h. Also move ath11k_debugfs_htt_stats_req() at the same time. And create a stub also for ath11k_debugfs_htt_stats_init() for consistency, even if it's not needed. Reported-by: kernel test robot <lkp@intel.com> Fixes: 568f060 ("ath11k: debugfs: move some function declarations to correct header files") Signed-off-by: Kalle Valo <kvalo@codeaurora.org> Link: https://lore.kernel.org/r/1601024241-16594-1-git-send-email-kvalo@codeaurora.org
1 parent 5b365af commit bc8befe

File tree

2 files changed

+20
-10
lines changed

2 files changed

+20
-10
lines changed

drivers/net/wireless/ath/ath11k/debugfs.h

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -173,11 +173,6 @@ static inline void ath11k_debugfs_unregister(struct ath11k *ar)
173173
{
174174
}
175175

176-
static inline void ath11k_dbg_htt_ext_stats_handler(struct ath11k_base *ab,
177-
struct sk_buff *skb)
178-
{
179-
}
180-
181176
static inline void ath11k_debugfs_fw_stats_process(struct ath11k_base *ab,
182177
struct sk_buff *skb)
183178
{
@@ -197,11 +192,6 @@ static inline int ath11k_debugfs_is_extd_rx_stats_enabled(struct ath11k *ar)
197192
return 0;
198193
}
199194

200-
static inline int ath11k_debugfs_htt_stats_req(struct ath11k *ar)
201-
{
202-
return 0;
203-
}
204-
205195
static inline bool ath11k_debugfs_is_pktlog_lite_mode_enabled(struct ath11k *ar)
206196
{
207197
return false;

drivers/net/wireless/ath/ath11k/debugfs_htt_stats.h

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1685,9 +1685,29 @@ struct htt_ring_backpressure_stats_tlv {
16851685
u32 backpressure_hist[5];
16861686
};
16871687

1688+
#ifdef CONFIG_ATH11K_DEBUGFS
1689+
16881690
void ath11k_debugfs_htt_stats_init(struct ath11k *ar);
16891691
void ath11k_debugfs_htt_ext_stats_handler(struct ath11k_base *ab,
16901692
struct sk_buff *skb);
16911693
int ath11k_debugfs_htt_stats_req(struct ath11k *ar);
16921694

1695+
#else /* CONFIG_ATH11K_DEBUGFS */
1696+
1697+
static inline void ath11k_debugfs_htt_stats_init(struct ath11k *ar)
1698+
{
1699+
}
1700+
1701+
static inline void ath11k_debugfs_htt_ext_stats_handler(struct ath11k_base *ab,
1702+
struct sk_buff *skb)
1703+
{
1704+
}
1705+
1706+
static inline int ath11k_debugfs_htt_stats_req(struct ath11k *ar)
1707+
{
1708+
return 0;
1709+
}
1710+
1711+
#endif /* CONFIG_ATH11K_DEBUGFS */
1712+
16931713
#endif

0 commit comments

Comments
 (0)